[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

Simon Atanasyan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 02:04:22 PDT 2018

atanasyan added a comment.

In https://reviews.llvm.org/D51234#1213813, @ruiu wrote:

> If this piece of code used to be working correctly, there is another piece of code that adds `-flavor ld` to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept `-flavor` option.
> So my guess is this code is dead. Or, am I missing something?

The `tools::gnutools::Linker::ConstructJob` method contains code which adds `-flavor old-gnu` command line option if linker name is "lld". Probably this code can be removed now.



More information about the cfe-commits mailing list