[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

Fāng-ruì Sòng via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 27 11:25:10 PDT 2018


On 2018-08-27, Rui Ueyama via Phabricator wrote:
>ruiu added a comment.
>
>If this piece of code used to be working correctly, there is another piece of code that adds `-flavor ld` to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept `-flavor` option.
>
>So my guess is this code is dead. Or, am I missing something?

I also suspect the code is dead.

@chandlerc fixed the related test (which I had not noticed when I committed the change) in https://reviews.llvm.org/rL340727
But the support of -flavor old-gnu was removed in 2016 https://reviews.llvm.org/rLLD262158

>
>
>Repository:
>  rL LLVM
>
>https://reviews.llvm.org/D51234
>
>
>

-- 
宋方睿


More information about the cfe-commits mailing list