[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 00:53:00 PDT 2018

hokein added a comment.

Please rebase your patch, since the absl matcher patch is submitted. Thanks.

Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:8
+#include "absl/external-file.h"
+// CHECK: absl/external-file.h:1:23: warning: do not reference any 'internal' namespaces; those implementation details are reserved to Abseil [abseil-no-internal-deps]
hugoeg wrote:
> hokein wrote:
> > Does the test get passed on the first run `RUN: %check_clang_tidy %s abseil-no-internal-deps %t,  -- -- -I %S/Inputs` of the test? It will suppress clang-tidy warnings from the header, and the warning here should not appear.
> Yes, the test passes cleanly on both runs, I just re ran it a couple times to make sure. 
Yeah, I misread it as `CHECK-MESSAGE`.


More information about the cfe-commits mailing list