[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 00:50:39 PDT 2018

hokein closed this revision.
hokein added a comment.

I have committed the patch for you,  https://reviews.llvm.org/rL340800.

Comment at: test/clang-tidy/abseil-no-namespace.cpp:10
+#include "absl/external-file.h"
+// CHECK: absl/external-file.h:1:11: warning: namespace 'absl' is reserved
+// for implementation of the Abseil library and should not be opened in user
deannagarcia wrote:
> hokein wrote:
> > Does the test get passed on the first command `%check_clang_tidy %s abseil-no-namespace %t -- -- -I %S/Inputs`? The first command will suppress all warning in headers, I think it will fail?
> The test passes, and I'm pretty sure it's because this is a CHECK not a CHECK-MESSAGES
Ah, I thought it was `CHECK-MESSAGES`, note that `CHECK` and `CHECK-MESSAGE` don't match multiple lines, the message should be one-line. I have fixed for you.


More information about the cfe-commits mailing list