[PATCH] D49840: [AST] Add MatchFinder::matchSubtree

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 27 01:27:17 PDT 2018

On Mon, Aug 6, 2018 at 4:47 PM Gabor Marton via Phabricator <
reviews at reviews.llvm.org> wrote:

> martong added a comment.
> Ping.
> Manuel, I still don't see how could we apply `match(anyOf(node),
> hasDescendant(node))` to the problem of general subtree traversal.
> (I'd like to have support for not just `decl()` but other kind of nodes
> too.)
Could you please advise how to move on? Also, could you please describe
> your specific technical arguments against this patch?

I'm still trying to understand why it's a good idea :) The general
technical argument why I'm asking all these questions is that we shouldn't
add new things unless they provide significant new features.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180827/7804d3ad/attachment-0001.html>

More information about the cfe-commits mailing list