[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 23 06:05:15 PDT 2018
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM. Many thanks!
See the NIT about avoiding the helper class too.
================
Comment at: clangd/Threading.cpp:88
+ llvm::llvm_execute_on_thread_async(
+ Callable{Name.str(), std::move(Action), std::move(CleanupTask)},
+ clang::DesiredStackSize);
----------------
NIT: we usually do the following to avoid writing those classes (not great, but arguably a bit less boilerplate):
```
// 'Bind' is in 'Function.h'
Bind([](decltype(ThreadFunc) ThreadFunc, decltype(CleanupTask), std::string ThreadName) {
// ... code
},
std::move(Action), std::move(CelanupTask), std::move(ThreadName));
```
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
More information about the cfe-commits
mailing list