[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 23 01:59:14 PDT 2018
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This part looks good (I think everything controversial got moved into the other patch). Thanks!
================
Comment at: clangd/Threading.cpp:75
+ std::string ThreadName;
+ decltype(Action) ThreadFunc;
+ decltype(CleanupTask) Cleanup;
----------------
nit: maybe call these CallAction and CallCleanupTask or something to make the parallels completely explicit. Up to you
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
More information about the cfe-commits
mailing list