[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 15 09:11:15 PDT 2018


hubert.reinterpretcast added a comment.

In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote:

> Is this test that's being added libc++ specific, or would it apply to other implementations as well?


The test can apply to other implementations as well (although I am not sure how the `initializer_list` include behaves under C++03 on other implementations). Is there some other place to put such tests?



================
Comment at: test/libcxx/numerics/rand/rand.eng.mers/cnstr_sseq_all_zero.pass.cpp:47
+
+template <typename result_type, std::size_t word_size> void test(void) {
+  const std::size_t state_size = 1u;
----------------
mclow.lists wrote:
> Need a line break before `void`
I have no objection to adding a line break, but I would like to clarify that this line came straight out of a recent build of `clang-format` with `--style=llvm`. I would like to know whether there is something else here that I should be doing with `clang-format`, including if it is deemed that `clang-format` does not do the right thing here.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50736





More information about the cfe-commits mailing list