[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Is this test that's being added libc++ specific, or would it apply to other implementations as well?



================
Comment at: test/libcxx/numerics/rand/rand.eng.mers/cnstr_sseq_all_zero.pass.cpp:18
+
+// template <class Sseq> explicit mersenne_twister_engine(Sseq &q);
+
----------------
Please add a comment here about what's being tested, because when I look at this a year from now, I won't know what's going on.

Something like:
`//  Finally, if the most significant w − r bits of X−n are zero, and if each of the other resulting Xi is 0, changes X−n to 2w−1.`



================
Comment at: test/libcxx/numerics/rand/rand.eng.mers/cnstr_sseq_all_zero.pass.cpp:47
+
+template <typename result_type, std::size_t word_size> void test(void) {
+  const std::size_t state_size = 1u;
----------------
Need a line break before `void`


Repository:
  rCXX libc++

https://reviews.llvm.org/D50736