[PATCH] D50154: [clangd] capitalize diagnostic messages

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 7 09:25:25 PDT 2018


What's the motivation for clangd to differ from clang here? (& if the first
letter is going to be capitalized, should there be a period at the end? But
also the phrasing of most/all diagnostic text isn't in the form of complete
sentences, so this might not make sense)

On Fri, Aug 3, 2018 at 1:44 PM Alex Lorenz via Phabricator via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rCTE338919: [clangd] capitalize diagnostic messages
> (authored by arphaman, committed by ).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D50154?vs=159059&id=159080#toc
>
> Repository:
>   rCTE Clang Tools Extra
>
> https://reviews.llvm.org/D50154
>
> Files:
>   clangd/Diagnostics.cpp
>   test/clangd/diagnostics.test
>   test/clangd/did-change-configuration-params.test
>   test/clangd/execute-command.test
>   test/clangd/extra-flags.test
>   test/clangd/fixits.test
>   unittests/clangd/ClangdUnitTests.cpp
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180807/f94dff7f/attachment.html>


More information about the cfe-commits mailing list