<div dir="ltr">What's the motivation for clangd to differ from clang here? (& if the first letter is going to be capitalized, should there be a period at the end? But also the phrasing of most/all diagnostic text isn't in the form of complete sentences, so this might not make sense)</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 3, 2018 at 1:44 PM Alex Lorenz via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rCTE338919: [clangd] capitalize diagnostic messages (authored by arphaman, committed by ).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D50154?vs=159059&id=159080#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50154?vs=159059&id=159080#toc</a><br>
<br>
Repository:<br>
  rCTE Clang Tools Extra<br>
<br>
<a href="https://reviews.llvm.org/D50154" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50154</a><br>
<br>
Files:<br>
  clangd/Diagnostics.cpp<br>
  test/clangd/diagnostics.test<br>
  test/clangd/did-change-configuration-params.test<br>
  test/clangd/execute-command.test<br>
  test/clangd/extra-flags.test<br>
  test/clangd/fixits.test<br>
  unittests/clangd/ClangdUnitTests.cpp<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>