[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 04:46:08 PDT 2018

ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.

Comment at: clangd/TUScheduler.cpp:381
+      DiagsWereReported = PrevDiagsWereReported;
+      if (DiagsWereReported) {
+        // Take a shortcut and don't report the diagnostics, since they should
ioeric wrote:
> I think checking `PrevDiagsWereReported` here would be more straightforward.
Good point. Done.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list