[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 31 04:42:44 PDT 2018
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/TUScheduler.cpp:381
+ DiagsWereReported = PrevDiagsWereReported;
+ if (DiagsWereReported) {
+ // Take a shortcut and don't report the diagnostics, since they should
----------------
I think checking `PrevDiagsWereReported` here would be more straightforward.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50045
More information about the cfe-commits
mailing list