r338291 - Remove trailing space

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 15:00:19 PDT 2018

On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng <maskray at google.com> wrote:
> Does this apply to only public headers (include/llvm include/llvm-c
> include/clang ...) or everything? (lib/**/*.{cpp,h})?

I've understood it applies to "everything" in that you should not
commit large-scale NFC changes that don't have considerable benefit
(for some definition of considerable benefit). e.g., if you're fixing
a typo in an API and it hits a lot of files, that's fine because a
typo in an API is pretty egregious, but don't clang-format a bunch of
files and commit that because formatting isn't super critical and
instead we migrate it more slowly as the code gets touched.

On Mon, Jul 30, 2018 at 4:49 PM, Fāng-ruì Sòng <maskray at google.com> wrote:
> Maybe not too terrible for out-of-tree projects. If they use git
> mirror, `git rebase` is smart enough to ignore changing lines with
> trailing whitespace (if not, there is git rebase
> -Xignore-space-at-eol). Some editors are configured with highlighting
> trailing spaces and these spaces will turn to eyesore...

Not everyone uses git; svn is still the official repository for the project.


More information about the cfe-commits mailing list