r338291 - Remove trailing space

Fāng-ruì Sòng via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 13:49:45 PDT 2018

Maybe not too terrible for out-of-tree projects. If they use git
mirror, `git rebase` is smart enough to ignore changing lines with
trailing whitespace (if not, there is git rebase
-Xignore-space-at-eol). Some editors are configured with highlighting
trailing spaces and these spaces will turn to eyesore...

On Mon, Jul 30, 2018 at 1:36 PM Aaron Ballman <aaron at aaronballman.com> wrote:
> On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse
> <llvm-commits at meinersbur.de> wrote:
> > I think removing trailing space is a good thing. Some editors remove
> > any trailing space when saving a file. This shows up in diffs that I
> > then have to undo manually.
> I've also run into the same issues on occasion. However, this isn't
> about whether we dislike trailing spaces or not; it's about NFC churn
> for out of tree users who have to try to keep their local patches
> clean against upstream. This kind of churn makes for merge conflicts
> and this is a the reason the community has traditionally rejected
> these large-scale commits in the past. If we want to change that
> policy, it should come after community discussion and agreement.
> ~Aaron


More information about the cfe-commits mailing list