[PATCH] D49844: [AST] Add a isActuallyImplicitCast() helper to the CastExpr class.
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 26 13:28:24 PDT 2018
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
In https://reviews.llvm.org/D49844#1177273, @rsmith wrote:
> What I requested was that either we make `CastExpr::isPartOfExplicitCast()` return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move `isPartOfExplicitCast` do the `ImplicitCastExpr` derived class. We don't need to do both, and since we're doing the latter in https://reviews.llvm.org/D49838, we don't need to do anything else. (Essentially, my request was to fix the bug that `CastExpr::isPartOfExplicitCast()` incorrectly returned `false` when called on an explicit cast expression, and I don't mind which way we fix it.)
Ok, no problem at atll, so i have read too much into it :)
I will then simply inline this into the only caller.
Repository:
rC Clang
https://reviews.llvm.org/D49844
More information about the cfe-commits
mailing list