[PATCH] D49844: [AST] Add a isActuallyImplicitCast() helper to the CastExpr class.

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

What I requested was that either we make `CastExpr::isPartOfExplicitCast()` return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move `isPartOfExplicitCast` do the `ImplicitCastExpr` derived class. We don't need to do both, and since we're doing the latter in https://reviews.llvm.org/D49838, we don't need to do anything else. (Essentially, my request was to fix the bug that `CastExpr::isPartOfExplicitCast()` incorrectly returned `false` when called on an explicit cast expression, and I don't mind which way we fix it.)


Repository:
  rC Clang

https://reviews.llvm.org/D49844