[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:2582
 /// yet; if a cleanup is required for the variable itself, that needs
 /// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
----------------
ahatanak wrote:
> rjmccall wrote:
> > Please document the meaning of the parameters here.
> One more question: I think documentation comments for public APIs are normally in the header file. Should we move these comments to CodeGenFunction.h? 
It'd be better, yeah.  Having it be on a unique implementation is also okay because it's not hard to find, but yeah, header is better.


Repository:
  rC Clang

https://reviews.llvm.org/D49718