[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 25 22:15:07 PDT 2018


ahatanak added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:2582
 /// yet; if a cleanup is required for the variable itself, that needs
 /// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
----------------
rjmccall wrote:
> Please document the meaning of the parameters here.
One more question: I think documentation comments for public APIs are normally in the header file. Should we move these comments to CodeGenFunction.h? 


Repository:
  rC Clang

https://reviews.llvm.org/D49718





More information about the cfe-commits mailing list