[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44
+// CHECK-0: ---
+// CHECK-0-NEXT: USR:             '06B5F6A19BA9F6A832E127C9968282B94619B210'
+// CHECK-0-NEXT: Name:            'C'
----------------
juliehockett wrote:
> ioeric wrote:
> > > Yes, in most regex worlds, but it doesn't work in FileCheck regex (complains about unbalanced braces).
> > Forgot this was `FileCheck` ;) Have you tried `[0-9A-Z]{{n}}`? If nothing works, I'd probably just  check length of one USR and use `{{.*}}` to match the rest of USRs in all tests.
> I can't wholly eliminate USRs from the tests (the bitcode ones use them as filenames), and so would the script I'm going to land from D49268 be sufficient? That way if the USR spec ever changes, it's fairly trivial to regen them all. 
Sure.

For script-generated tests, please make it's clear to other people, who might not be familiar with the tool, to figure out how to regenerate the tests, in case they make a change somewhere in clang and break your tests. E.g. a big comment on top of file indicating it's generated and pointing to the script. The script should also have clear instructions.


https://reviews.llvm.org/D48341