[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope
Julie Hockett via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 19 07:28:58 PDT 2018
juliehockett added inline comments.
Herald added a subscriber: arphaman.
================
Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44
+// CHECK-0: ---
+// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210'
+// CHECK-0-NEXT: Name: 'C'
----------------
ioeric wrote:
> > Yes, in most regex worlds, but it doesn't work in FileCheck regex (complains about unbalanced braces).
> Forgot this was `FileCheck` ;) Have you tried `[0-9A-Z]{{n}}`? If nothing works, I'd probably just check length of one USR and use `{{.*}}` to match the rest of USRs in all tests.
I can't wholly eliminate USRs from the tests (the bitcode ones use them as filenames), and so would the script I'm going to land from D49268 be sufficient? That way if the USR spec ever changes, it's fairly trivial to regen them all.
https://reviews.llvm.org/D48341
More information about the cfe-commits
mailing list