[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: test/OpenMP/nvptx_data_sharing.cpp:33
 // CK1: call void @llvm.nvvm.barrier0()
-// CK1: call void @__kmpc_data_sharing_init_stack
 
----------------
It is better to check that this call is not emitted, like this `CK1-NOT: call void @__kmpc_data_sharing_init_stack`


================
Comment at: test/OpenMP/nvptx_data_sharing_spmd.cpp:1-24
+// Test device global memory data sharing initialization codegen for spmd.
+///==========================================================================///
+
+// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc %s -o %t-ppc-host.bc
+// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-device -fopenmp-host-ir-file-path %t-ppc-host.bc -o - | FileCheck %s --check-prefix CK1
+
+// expected-no-diagnostics
----------------
I think we already have some tests with SPMD construct, you can just modify the existing tests instead of adding another one (e.g. `nvptx_target_parallel_codegen.cpp`)


Repository:
  rC Clang

https://reviews.llvm.org/D49188