[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea marked 2 inline comments as done.
gtbercea added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85
   OMPRTL_NVPTX__kmpc_data_sharing_init_stack,
+  /// Call to void __kmpc_data_sharing_init_stack_spmd();
+  OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd,
   /// Call to void* __kmpc_data_sharing_push_stack(size_t size,
----------------
Hahnfeld wrote:
> In case I'm not missing something obvious this function doesn't exist (yet) in libomptarget-nvptx?
Correct. There's a libomptarget patch coming up as well.


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:1110-1114
-  // For data sharing, we need to initialize the stack for workers.
-  CGF.EmitRuntimeCall(
-      createNVPTXRuntimeFunction(
-          OMPRTL_NVPTX__kmpc_data_sharing_init_stack));
-
----------------
Hahnfeld wrote:
> Why is this call being removed? There's no mention in the summary AFAICS
Not needed on workers after libomptarget patch. I could perhaps put this into a separate patch along with the test fix.


Repository:
  rC Clang

https://reviews.llvm.org/D49188