[PATCH] D48721: Patch to fix pragma metadata for do-while loops

Deepak Panickal via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 28 07:16:35 PDT 2018


>
> Phab is the correct way to submit patches.
> But having a bugreport in bugzilla is good too.
> But the test will be needed regardless of the patch submission method.
> And yes, please do always upload all patches with full context (`-U99999`).


Sorry about the context.
Can I add the test file to this patch itself? Or should that be another
patch?

On Thu, Jun 28, 2018 at 3:08 PM Deepak Panickal via Phabricator <
reviews at reviews.llvm.org> wrote:

> deepak2427 updated this revision to Diff 153316.
> deepak2427 added a comment.
>
> Add full context
>
>
> https://reviews.llvm.org/D48721
>
> Files:
>   lib/CodeGen/CGStmt.cpp
>
>
> Index: lib/CodeGen/CGStmt.cpp
> ===================================================================
> --- lib/CodeGen/CGStmt.cpp
> +++ lib/CodeGen/CGStmt.cpp
> @@ -777,19 +777,19 @@
>    // Emit the body of the loop.
>    llvm::BasicBlock *LoopBody = createBasicBlock("do.body");
>
> -  const SourceRange &R = S.getSourceRange();
> -  LoopStack.push(LoopBody, CGM.getContext(), DoAttrs,
> -                 SourceLocToDebugLoc(R.getBegin()),
> -                 SourceLocToDebugLoc(R.getEnd()));
> -
>    EmitBlockWithFallThrough(LoopBody, &S);
>    {
>      RunCleanupsScope BodyScope(*this);
>      EmitStmt(S.getBody());
>    }
>
>    EmitBlock(LoopCond.getBlock());
>
> +  const SourceRange &R = S.getSourceRange();
> +  LoopStack.push(LoopBody, CGM.getContext(), DoAttrs,
> +                 SourceLocToDebugLoc(R.getBegin()),
> +                 SourceLocToDebugLoc(R.getEnd()));
> +
>    // C99 6.8.5.2: "The evaluation of the controlling expression takes
> place
>    // after each execution of the loop body."
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180628/093cb6ec/attachment.html>


More information about the cfe-commits mailing list