<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Phab is the correct way to submit patches.<br></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">But having a bugreport in bugzilla is good too.<br></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">But the test will be needed regardless of the patch submission method.<br></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">And yes, please do always upload all patches with full context (`-U99999`).</span></blockquote><div class="m_4701794561955055037gmail-yj6qo m_4701794561955055037gmail-ajU" style="outline:none;padding:10px 0px;width:22px;margin:2px 0px 0px;color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div><div>Sorry about the context.</div><div>Can I add the test file to this patch itself? Or should that be another patch?</div><div><br></div><div class="gmail_quote"><div dir="ltr">On Thu, Jun 28, 2018 at 3:08 PM Deepak Panickal via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">deepak2427 updated this revision to Diff 153316.<br>
deepak2427 added a comment.<br>
<br>
Add full context<br>
<br>
<br>
<a href="https://reviews.llvm.org/D48721" rel="noreferrer" target="_blank">https://reviews.llvm.org/D48721</a><br>
<br>
Files:<br>
  lib/CodeGen/CGStmt.cpp<br>
<br>
<br>
Index: lib/CodeGen/CGStmt.cpp<br>
===================================================================<br>
--- lib/CodeGen/CGStmt.cpp<br>
+++ lib/CodeGen/CGStmt.cpp<br>
@@ -777,19 +777,19 @@<br>
   // Emit the body of the loop.<br>
   llvm::BasicBlock *LoopBody = createBasicBlock("do.body");<br>
<br>
-  const SourceRange &R = S.getSourceRange();<br>
-  LoopStack.push(LoopBody, CGM.getContext(), DoAttrs,<br>
-                 SourceLocToDebugLoc(R.getBegin()),<br>
-                 SourceLocToDebugLoc(R.getEnd()));<br>
-<br>
   EmitBlockWithFallThrough(LoopBody, &S);<br>
   {<br>
     RunCleanupsScope BodyScope(*this);<br>
     EmitStmt(S.getBody());<br>
   }<br>
<br>
   EmitBlock(LoopCond.getBlock());<br>
<br>
+  const SourceRange &R = S.getSourceRange();<br>
+  LoopStack.push(LoopBody, CGM.getContext(), DoAttrs,<br>
+                 SourceLocToDebugLoc(R.getBegin()),<br>
+                 SourceLocToDebugLoc(R.getEnd()));<br>
+<br>
   // C99 <a href="http://6.8.5.2" rel="noreferrer" target="_blank">6.8.5.2</a>: "The evaluation of the controlling expression takes place<br>
   // after each execution of the loop body."<br>
<br>
<br>
<br>
</blockquote></div></div>