[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 27 23:42:47 PDT 2018


EricWF added a comment.

LGTM, but I'm a bit confused. You seem to argue that no system places C++ headers on the default search paths, but also that it would be a problem if such a system did.
Why wouldn't the conclusion be true? That is, although C++ includes aren't normally found along the default paths, when they are found, we should still consider them?

That being said, the current behavior of searching certian default include paths first does seem incorrect. So I'm OK with disabling it.

I also agree that we shouldn't necessarily be looking for `vector` header, how about looking for `__config` instead, since it's libc++ specific?


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D48694





More information about the cfe-commits mailing list