[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 27 17:58:23 PDT 2018


smeenai added a comment.

This doesn't map to any command line change; it's purely a CMake thing. It just changes where libc++abi's build system looks for libc++ headers. Before this patch, it would look for a file named "vector" in all the standard system include directories (`/usr/local/include`, `/usr/include`, anything else in your PATH, etc.) and then look for it in the paths specified by the PATHS argument. After this patch it will only look for that file in the paths specified by the PATHS argument. The actual value of LIBCXXABI_LIBCXX_INCLUDES gets added to the header search path when compiling the libc++abi sources, but this diff isn't changing that part (it just potentially changes the value that gets computed for LIBCXXABI_LIBCXX_INCLUDES, but as I detailed in the description I don't think that should actually change on any system I'm aware of, and if it does cause a change then there's a good chance the old value was incorrect).


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D48694





More information about the cfe-commits mailing list