r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

Tue Jun 26 19:17:24 PDT 2018

Ah - thanks for fixing that. Surprised none of the bots hit it.
Teresa

On Tue, Jun 26, 2018 at 4:24 PM Shoaib Meenai <smeenai at fb.com> wrote:

> Ah, my llvm-as was indeed out of date. I made check-clang depend on
> llvm-as in r335686 to avoid this issue in the future.
>
>
>
> *From: *Teresa Johnson <tejohnson at google.com>
> *Date: *Tuesday, June 26, 2018 at 4:11 PM
> *To: *Shoaib Meenai <smeenai at fb.com>
> *Cc: *"cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
> *Subject: *Re: r335618 - [ThinLTO] Add testing of summary index parsing
> to a couple CFI tests
>
>
>
> I haven't seen any bot failures for the change. The failing check was
> there before, so presumably llvm-dis on its own is producing the expected
> lines, just not when it goes through llvm-as. Can you let me know whether
> llvm-as has been updated and whether it gives an error. Note that there
> were a number of other similar test changes committed in the main llvm-side
> patch D47905 shortly before this one. Are any of those failing for you?
>
> Teresa
>
> On Tue, Jun 26, 2018, 3:47 PM Shoaib Meenai <smeenai at fb.com> wrote:
>
> The check lines added here are failing for me on CentOS 7.
> https://reviews.llvm.org/P8091
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_P8091&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Jy48KWhDHTfiRkUh6D6LWptKpx92vz5VpkWaHVCjHCE&s=rLSAJBQEXnuVpqtESj1BaYt_bapa7spVBuaonbJHWZ8&e=>
> has the lit output and the actual output being produced by one of the added
> RUN lines. My llvm and clang repositories are in sync. Any idea what might
> be going on here?
>
>
>
> *From: *cfe-commits <cfe-commits-bounces at lists.llvm.org> on behalf of
> Teresa Johnson via cfe-commits <cfe-commits at lists.llvm.org>
> *Reply-To: *Teresa Johnson <tejohnson at google.com>
> *Date: *Tuesday, June 26, 2018 at 8:55 AM
> *To: *"cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
> *Subject: *r335618 - [ThinLTO] Add testing of summary index parsing to a
> couple CFI tests
>
>
>
> Author: tejohnson
>
> Date: Tue Jun 26 08:50:34 2018
>
> New Revision: 335618
>
>
>
> URL:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D335618-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=sFcyz-6EIWKbnsSlIcghgfqpuW73fEF48XuoUDzbohk&e=
>
> Log:
>
> [ThinLTO] Add testing of summary index parsing to a couple CFI tests
>
>
>
> Summary:
>
> Changes to some clang side tests to go with the summary parsing patch.
>
>
>
> Depends on D47905.
>
>
>
> Reviewers: pcc, dexonsmith, mehdi_amini
>
>
>
> Subscribers: inglorion, eraman, cfe-commits, steven_wu
>
>
>
> Differential Revision:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D47906&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=jQWcXM3uTGYSu5wgYQ_0NcHaJj9V9DOBoJcL8bxbjc4&e=
>
>
>
> Modified:
>
>     cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
>
>     cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll
>
>
>
> Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
>
> URL:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi-2Ddevirt.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=DQBuDzMNex1JeoqLkc4S9ZTXRVWN2wCcbmk3U7hzKDQ&e=
>
>
> ==============================================================================
>
> --- cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll (original)
>
> +++ cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Tue Jun 26
> 08:50:34 2018
>
> @@ -30,6 +30,8 @@
>
> ; CHECK-LABEL: </STRTAB_BLOCK
>
> ; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s
> --check-prefix=CHECK-DIS
>
> +; Round trip it through llvm-as
>
> +; RUN: llvm-dis %t.o.thinlto.bc -o - | llvm-as -o - | llvm-dis -o - |
> FileCheck %s --check-prefix=CHECK-DIS
>
> ; CHECK-DIS: ^0 = module: (path:
> "{{.*}}thinlto-distributed-cfi-devirt.ll.tmp.o", hash: ({{.*}}, {{.*}},
> {{.*}}, {{.*}}, {{.*}}))
>
> ; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function:
> (module: ^0, flags: (linkage: external, notEligibleToImport: 0, live: 1,
> dsoLocal: 0), insts: 18, typeIdInfo: (typeTests: (^2),
> typeCheckedLoadVCalls: (vFuncId: (^2, offset: 8), vFuncId: (^2, offset:
> 0))))))
>
> ; CHECK-DIS: ^2 = typeid: (name: "_ZTS1A", summary: (typeTestRes: (kind:
> allOnes, sizeM1BitWidth: 7), wpdResolutions: ((offset: 0, wpdRes: (kind:
> branchFunnel)), (offset: 8, wpdRes: (kind: singleImpl, singleImplName:
> "_ZN1A1nEi"))))) ; guid = 7004155349499253778
>
>
>
> Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll
>
> URL:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=PAH2s9gPirL0F8r0JQYFEoT0zKAnd6n9XnhXUvluugU&e=
>
>
> ==============================================================================
>
> --- cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll (original)
>
> +++ cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll Tue Jun 26 08:50:34
> 2018
>
> @@ -21,6 +21,8 @@
>
> ; CHECK-LABEL: </STRTAB_BLOCK
>
> ; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s
> --check-prefix=CHECK-DIS
>
> +; Round trip it through llvm-as
>
> +; RUN: llvm-dis %t.o.thinlto.bc -o - | llvm-as -o - | llvm-dis -o - |
> FileCheck %s --check-prefix=CHECK-DIS
>
> ; CHECK-DIS: ^0 = module: (path: "{{.*}}thinlto-distributed-cfi.ll.tmp.o",
> hash: ({{.*}}, {{.*}}, {{.*}}, {{.*}}, {{.*}}))
>
> ; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function:
> (module: ^0, flags: (linkage: external, notEligibleToImport: 0, live: 1,
> dsoLocal: 0), insts: 7, typeIdInfo: (typeTests: (^2)))))
>
> ; CHECK-DIS: ^2 = typeid: (name: "_ZTS1A", summary: (typeTestRes: (kind:
> single, sizeM1BitWidth: 0))) ; guid = 7004155349499253778
>
>
>
>
>
> _______________________________________________
>
> cfe-commits mailing list
>
> cfe-commits at lists.llvm.org
>
>
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=xZ7KB8LgXcujdQpqz54h14kTUJ7Tpf8hTlHsd_q2Atk&e=
>
>
>
>

-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180626/7bfa69e6/attachment.html>