<div dir="ltr">Ah - thanks for fixing that. Surprised none of the bots hit it.<div>Teresa</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 26, 2018 at 4:24 PM Shoaib Meenai <<a href="mailto:smeenai@fb.com">smeenai@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-4146600309427044645WordSection1">
<p class="MsoNormal">Ah, my llvm-as was indeed out of date. I made check-clang depend on llvm-as in r335686 to avoid this issue in the future.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Teresa Johnson <<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>><br>
<b>Date: </b>Tuesday, June 26, 2018 at 4:11 PM<br>
<b>To: </b>Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Cc: </b>"<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><u></u> <u></u></p>
</div>
<p class="MsoNormal" style="margin-left:.5in">I haven't seen any bot failures for the change. The failing check was there before, so presumably llvm-dis on its own is producing the expected lines, just not when it goes through llvm-as. Can you let me know whether
llvm-as has been updated and whether it gives an error. Note that there were a number of other similar test changes committed in the main llvm-side patch D47905 shortly before this one. Are any of those failing for you?
<u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">
Teresa<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in">On Tue, Jun 26, 2018, 3:47 PM Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in">
The check lines added here are failing for me on CentOS 7. <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_P8091&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Jy48KWhDHTfiRkUh6D6LWptKpx92vz5VpkWaHVCjHCE&s=rLSAJBQEXnuVpqtESj1BaYt_bapa7spVBuaonbJHWZ8&e=" target="_blank">
https://reviews.llvm.org/P8091</a> has the lit output and the actual output being produced by one of the added RUN lines. My llvm and clang repositories are in sync. Any idea what might be going on here?<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:.5in">
<u></u><u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:1.0in">
<b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">cfe-commits <<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.llvm.org</a>> on behalf of Teresa Johnson via
cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Reply-To: </b>Teresa Johnson <<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>><br>
<b>Date: </b>Tuesday, June 26, 2018 at 8:55 AM<br>
<b>To: </b>"<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Subject: </b>r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Author: tejohnson<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Date: Tue Jun 26 08:50:34 2018<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
New Revision: 335618<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D335618-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=sFcyz-6EIWKbnsSlIcghgfqpuW73fEF48XuoUDzbohk&e=" target="_blank">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D335618-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=sFcyz-6EIWKbnsSlIcghgfqpuW73fEF48XuoUDzbohk&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Log:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
[ThinLTO] Add testing of summary index parsing to a couple CFI tests<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Summary:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Changes to some clang side tests to go with the summary parsing patch.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Depends on D47905.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Reviewers: pcc, dexonsmith, mehdi_amini<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Subscribers: inglorion, eraman, cfe-commits, steven_wu<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D47906&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=jQWcXM3uTGYSu5wgYQ_0NcHaJj9V9DOBoJcL8bxbjc4&e=" target="_blank">
https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D47906&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=jQWcXM3uTGYSu5wgYQ_0NcHaJj9V9DOBoJcL8bxbjc4&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Modified:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi-2Ddevirt.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=DQBuDzMNex1JeoqLkc4S9ZTXRVWN2wCcbmk3U7hzKDQ&e=" target="_blank">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi-2Ddevirt.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=DQBuDzMNex1JeoqLkc4S9ZTXRVWN2wCcbmk3U7hzKDQ&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
==============================================================================<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
--- cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll (original)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+++ cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Tue Jun 26 08:50:34 2018<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
@@ -30,6 +30,8 @@<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-LABEL: </STRTAB_BLOCK<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s --check-prefix=CHECK-DIS<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+; Round trip it through llvm-as<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+; RUN: llvm-dis %t.o.thinlto.bc -o - | llvm-as -o - | llvm-dis -o - | FileCheck %s --check-prefix=CHECK-DIS<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^0 = module: (path: "{{.*}}thinlto-distributed-cfi-devirt.ll.tmp.o", hash: ({{.*}}, {{.*}}, {{.*}}, {{.*}}, {{.*}}))<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function: (module: ^0, flags: (linkage: external, notEligibleToImport: 0, live: 1, dsoLocal: 0), insts: 18, typeIdInfo: (typeTests: (^2), typeCheckedLoadVCalls: (vFuncId: (^2, offset: 8), vFuncId:
(^2, offset: 0))))))<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^2 = typeid: (name: "_ZTS1A", summary: (typeTestRes: (kind: allOnes, sizeM1BitWidth: 7), wpdResolutions: ((offset: 0, wpdRes: (kind: branchFunnel)), (offset: 8, wpdRes: (kind: singleImpl, singleImplName: "_ZN1A1nEi"))))) ; guid = 7004155349499253778<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=PAH2s9gPirL0F8r0JQYFEoT0zKAnd6n9XnhXUvluugU&e=" target="_blank">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_thinlto-2Ddistributed-2Dcfi.ll-3Frev-3D335618-26r1-3D335617-26r2-3D335618-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=PAH2s9gPirL0F8r0JQYFEoT0zKAnd6n9XnhXUvluugU&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
==============================================================================<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
--- cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll (original)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+++ cfe/trunk/test/CodeGen/thinlto-distributed-cfi.ll Tue Jun 26 08:50:34 2018<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
@@ -21,6 +21,8 @@<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-LABEL: </STRTAB_BLOCK<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s --check-prefix=CHECK-DIS<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+; Round trip it through llvm-as<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
+; RUN: llvm-dis %t.o.thinlto.bc -o - | llvm-as -o - | llvm-dis -o - | FileCheck %s --check-prefix=CHECK-DIS<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^0 = module: (path: "{{.*}}thinlto-distributed-cfi.ll.tmp.o", hash: ({{.*}}, {{.*}}, {{.*}}, {{.*}}, {{.*}}))<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function: (module: ^0, flags: (linkage: external, notEligibleToImport: 0, live: 1, dsoLocal: 0), insts: 7, typeIdInfo: (typeTests: (^2)))))<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
; CHECK-DIS: ^2 = typeid: (name: "_ZTS1A", summary: (typeTestRes: (kind: single, sizeM1BitWidth: 0))) ; guid = 7004155349499253778<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
_______________________________________________<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
cfe-commits mailing list<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=xZ7KB8LgXcujdQpqz54h14kTUJ7Tpf8hTlHsd_q2Atk&e=" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=t3QlYWXjMDXjKJ9zRV9gsXH-VakqyyLmPocT9T_axY8&s=xZ7KB8LgXcujdQpqz54h14kTUJ7Tpf8hTlHsd_q2Atk&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1.0in">
<u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>