[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: include/clang/Analysis/ConstructionContext.h:351
+
+  explicit SimpleTemporaryObjectConstructionContext(
+      const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE)
----------------
MTC wrote:
> MTC wrote:
> > `explicit` useless?
> I'm wrong here, maybe there is some use of `SimpleTemporaryObjectConstructionContext({ , })`, sorry to bother!
Well, i really doubt it'd ever matter (given that the constructor is also private, we can pretty much control all constructions by hand) but i think it's a good practice to add the restriction unless implicit construction is actually important.


https://reviews.llvm.org/D47616