[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

Henry Wong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 12 00:00:47 PDT 2018


MTC added inline comments.
Herald added a subscriber: mikhail.ramalho.


================
Comment at: include/clang/Analysis/ConstructionContext.h:351
+
+  explicit SimpleTemporaryObjectConstructionContext(
+      const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE)
----------------
MTC wrote:
> `explicit` useless?
I'm wrong here, maybe there is some use of `SimpleTemporaryObjectConstructionContext({ , })`, sorry to bother!


================
Comment at: include/clang/Analysis/ConstructionContext.h:377
+
+  explicit ElidedTemporaryObjectConstructionContext(
+      const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE,
----------------
MTC wrote:
> Same useless here?
Also I'm wrong here!


https://reviews.llvm.org/D47616





More information about the cfe-commits mailing list