r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

[Hans Wennborg via cfe-commits]

I've reverted in r334493 in the meantime.

When I run the tests locally, they fail with:

# command stderr:
C:\src\llvm\tools\clang\test\Driver\crash-report.c:17:11: error:
expected string not found in input
// CHECK: Preprocessed source(s) and associated run script(s) are located at:
          ^
<stdin>:1:1: note: scanning from here
Error: Unable to find `env' in PATH: no such file or directory

Looking at TestRunner.py:823, I suspect the internal shell doesn't
handle 'env' when it's not the first part of a command.

Actually, maybe switching the order from "not env ... %clang" to "env
... not %clang" might work...

On Tue, Jun 12, 2018 at 4:15 AM, via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Hi Reid,
>
> Actually, it seems all four tests you changed are failing on one Windows bot http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12464.
>
> Can you please take a look and fix the tests?
>
> Douglas Yung
>
>> -----Original Message-----
>> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf
>> Of via cfe-commits
>> Sent: Monday, June 11, 2018 18:37
>> To: rnk at google.com
>> Cc: cfe-commits at lists.llvm.org
>> Subject: RE: r334418 - Enable crash recovery tests on Windows, globs
>> work in the lit internal shell now
>>
>> Hi Reid,
>>
>> I don't know if you noticed, but one of the tests you changed with this
>> commit is failing on the PS4 Windows bot. Can you take a look?
>>
>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-
>> windows10pro-fast/builds/17695/