r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 11 19:15:23 PDT 2018 

Hi Reid,

Actually, it seems all four tests you changed are failing on one Windows bot http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12464.

Can you please take a look and fix the tests?

Douglas Yung

> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf
> Of via cfe-commits
> Sent: Monday, June 11, 2018 18:37
> To: rnk at google.com
> Cc: cfe-commits at lists.llvm.org
> Subject: RE: r334418 - Enable crash recovery tests on Windows, globs
> work in the lit internal shell now
> 
> Hi Reid,
> 
> I don't know if you noticed, but one of the tests you changed with this
> commit is failing on the PS4 Windows bot. Can you take a look?
> 
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast/builds/17695/
> 
> FAIL: Clang :: Driver/crash-report-modules.m (7229 of 40862)
> ******************** TEST 'Clang :: Driver/crash-report-modules.m'
> FAILED ********************
> Script:
> --
> : 'RUN: at line 1';   rm -rf C:\ps4-buildslave2\llvm-clang-lld-x86_64-
> scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-modules.m.tmp
> : 'RUN: at line 2';   mkdir -p C:\ps4-buildslave2\llvm-clang-lld-
> x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/i C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/m C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp
> : 'RUN: at line 4';   not env FORCE_CLANG_DIAGNOSTICS_CRASH=
> TMPDIR=C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-modules.m.tmp
> TEMP=C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-modules.m.tmp
> TMP=C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-modules.m.tmp
> c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\bin\clang.EXE -fsyntax-only C:\ps4-buildslave2\llvm-
> clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m -I C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver/Inputs/module -isysroot C:/ps4-
> buildslave2/llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast/llvm.obj/tools/clang/test/Driver/Output/crash-report-
> modules.m.tmp/i/     -fmodules -fmodules-cache-path=C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/m/ -DFOO=BAR 2>&1 | C:\ps4-buildslave2\llvm-clang-lld-
> x86_64-scei-ps4-windows10pro-fast\llvm.obj\bin\FileCheck.EXE C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m
> : 'RUN: at line 8';   C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-
> ps4-windows10pro-fast\llvm.obj\bin\FileCheck.EXE --check-
> prefix=CHECKSRC C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.src\tools\clang\test\Driver\crash-report-
> modules.m -input-file C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-
> ps4-windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-
> report-modules.m.tmp/crash-report-*.m
> : 'RUN: at line 9';   C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-
> ps4-windows10pro-fast\llvm.obj\bin\FileCheck.EXE --check-prefix=CHECKSH
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m -input-
> file C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/crash-report-*.sh
> --
> Exit Code: 2
> 
> Command Output (stdout):
> --
> $ ":" "RUN: at line 1"
> $ "rm" "-rf" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp"
> $ ":" "RUN: at line 2"
> $ "mkdir" "-p" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/i" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/m" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp"
> $ ":" "RUN: at line 4"
> $ "not" "env" "FORCE_CLANG_DIAGNOSTICS_CRASH=" "TMPDIR=C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp" "TEMP=C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp" "TMP=C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp" "c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\llvm.obj\bin\clang.EXE" "-fsyntax-only" "C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m" "-I"
> "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver/Inputs/module" "-isysroot"
> "C:/ps4-buildslave2/llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast/llvm.obj/tools/clang/test/Driver/Output/crash-report-
> modules.m.tmp/i/" "-fmodules" "-fmodules-cache-path=C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\tools\clang\test\Driver\Output\crash-report-
> modules.m.tmp/m/" "-DFOO=BAR"
> note: command had no output on stdout or stderr
> error: command failed with exit status: 1
> $ "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.obj\bin\FileCheck.EXE" "C:\ps4-buildslave2\llvm-clang-lld-
> x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m"
> # command stderr:
> FileCheck error: '-' is empty.
> 
> FileCheck command line:  C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-
> ps4-windows10pro-fast\llvm.obj\bin\FileCheck.EXE C:\ps4-
> buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-
> fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m
> 
> 
> error: command failed with exit status: 2
> 
> Douglas Yung
> 
> > -----Original Message-----
> > From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On
> Behalf
> > Of Reid Kleckner via cfe-commits
> > Sent: Monday, June 11, 2018 9:50
> > To: cfe-commits at lists.llvm.org
> > Subject: r334418 - Enable crash recovery tests on Windows, globs work
> > in the lit internal shell now
> >
> > Author: rnk
> > Date: Mon Jun 11 09:50:07 2018
> > New Revision: 334418
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=334418&view=rev
> > Log:
> > Enable crash recovery tests on Windows, globs work in the lit
> internal
> > shell now
> >
> > Modified:
> >     cfe/trunk/test/Driver/crash-report-header.h
> >     cfe/trunk/test/Driver/crash-report-modules.m
> >     cfe/trunk/test/Driver/crash-report-spaces.c
> >     cfe/trunk/test/Driver/crash-report.c
> >
> > Modified: cfe/trunk/test/Driver/crash-report-header.h
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash-
> > report-header.h?rev=334418&r1=334417&r2=334418&view=diff
> >
> =======================================================================
> > =======
> > --- cfe/trunk/test/Driver/crash-report-header.h (original)
> > +++ cfe/trunk/test/Driver/crash-report-header.h Mon Jun 11 09:50:07
> > 2018
> > @@ -5,9 +5,6 @@
> >  // RUN: cat %t/crash-report-header-*.sh | FileCheck --check-
> > prefix=CHECKSH "%s"
> >  // REQUIRES: crash-recovery
> >
> > -// because of the glob (*.h, *.sh)
> > -// REQUIRES: shell
> > -
> >  #pragma clang __debug parser_crash
> >  // CHECK: Preprocessed source(s) and associated run script(s) are
> > located at:
> >  // CHECK-NEXT: note: diagnostic msg: {{.*}}.h
> >
> > Modified: cfe/trunk/test/Driver/crash-report-modules.m
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash-
> > report-modules.m?rev=334418&r1=334417&r2=334418&view=diff
> >
> =======================================================================
> > =======
> > --- cfe/trunk/test/Driver/crash-report-modules.m (original)
> > +++ cfe/trunk/test/Driver/crash-report-modules.m Mon Jun 11 09:50:07
> > 2018
> > @@ -9,12 +9,6 @@
> >  // RUN: FileCheck --check-prefix=CHECKSH %s -input-file %t/crash-
> > report-*.sh
> >  // REQUIRES: crash-recovery
> >
> > -// because of the glob (*.m, *.sh)
> > -// REQUIRES: shell
> > -
> > -// FIXME: This XFAIL is cargo-culted from crash-report.c. Do we need
> > it?
> > -// XFAIL: mingw32
> > -
> >  @import simple;
> >  const int x = MODULE_MACRO;
> >
> > @@ -34,4 +28,4 @@ const int x = MODULE_MACRO;
> >  // CHECKSH: "-D" "FOO=BAR"
> >  // CHECKSH-NOT: "-fmodules-cache-path="
> >  // CHECKSH: "crash-report-modules-{{[^ ]*}}.m"
> > -// CHECKSH: "-ivfsoverlay" "crash-report-modules-{{[^
> > ]*}}.cache/vfs/vfs.yaml"
> > +// CHECKSH: "-ivfsoverlay" "crash-report-modules-{{[^
> > ]*}}.cache{{(/|\\\\)}}vfs{{(/|\\\\)}}vfs.yaml"
> >
> > Modified: cfe/trunk/test/Driver/crash-report-spaces.c
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash-
> > report-spaces.c?rev=334418&r1=334417&r2=334418&view=diff
> >
> =======================================================================
> > =======
> > --- cfe/trunk/test/Driver/crash-report-spaces.c (original)
> > +++ cfe/trunk/test/Driver/crash-report-spaces.c Mon Jun 11 09:50:07
> > 2018
> > @@ -6,9 +6,6 @@
> >  // RUN: cat "%t/crash report spaces"-*.sh | FileCheck --check-
> > prefix=CHECKSH "%s"
> >  // REQUIRES: crash-recovery
> >
> > -// because of the glob (*.c, *.sh)
> > -// REQUIRES: shell
> > -
> >  #pragma clang __debug parser_crash
> >  // CHECK: Preprocessed source(s) and associated run script(s) are
> > located at:
> >  // CHECK-NEXT: note: diagnostic msg: {{.*}}.c
> >
> > Modified: cfe/trunk/test/Driver/crash-report.c
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/crash-
> > report.c?rev=334418&r1=334417&r2=334418&view=diff
> >
> =======================================================================
> > =======
> > --- cfe/trunk/test/Driver/crash-report.c (original)
> > +++ cfe/trunk/test/Driver/crash-report.c Mon Jun 11 09:50:07 2018
> > @@ -13,9 +13,6 @@
> >  // RUN: cat %t/crash-report-*.sh | FileCheck --check-prefix=CHECKSH
> %s
> >  // REQUIRES: crash-recovery
> >
> > -// because of the glob (*.c, *.sh)
> > -// REQUIRES: shell
> > -
> >  #pragma clang __debug parser_crash
> >  // CHECK: Preprocessed source(s) and associated run script(s) are
> > located at:
> >  // CHECK-NEXT: note: diagnostic msg: {{.*}}crash-report-{{.*}}.c
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list