[PATCH] D47367: [ASTImporter] Add ms compatibility to tests which use the TestBase

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 29 07:15:41 PDT 2018


martong added a comment.

> I agree with that. I think we need to test just import pairs {/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2, option_2}, ...{option_n, option_n}.

This patch does exactly that with the parameterized tests. Each elements of the `DefaultTestValuesForRunOptions` will be used both for the "To" and for the "From" context.
So we will have each TEST_P generating 4 cases:
[FROM, TO]
{no_option, no_option}
{"-fdelayed-template-parsing", "-fdelayed-template-parsing"}
{"-fms-compatibility", "-fms-compatibility"}
{"-fdelayed-template-parsing -fms-compatibility", "-fdelayed-template-parsing -fms-compatibility"}


Repository:
  rC Clang

https://reviews.llvm.org/D47367





More information about the cfe-commits mailing list