[PATCH] D47367: [ASTImporter] Add ms compatibility to tests which use the TestBase

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 29 05:01:41 PDT 2018


a.sidorin added a comment.

> I think, it is overkill to test all possible combinations of the options, we should come up with something better here.

I agree with that. I think we need to test just import pairs {/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2, option_2}, ...{option_n, option_n}.
Another option is to just turn -fno-delayed-template-parsing -fno-ms-compatibility for ASTImporter tests like it is done in some unit tests, but I'm not sure it's a correct solution.


Repository:
  rC Clang

https://reviews.llvm.org/D47367





More information about the cfe-commits mailing list