[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In https://reviews.llvm.org/D42966#1085257, @mikhail.ramalho wrote:

> Should we ignore linemarkers and use filename + offset of the real file?


I would say "yes". Let's not rely on linemarkers, unless we can explain why that's a good idea.

> Should we try to calculate the offset of the decl in the virtual file?

Where do virtual files come from in the first place?


Repository:
  rC Clang

https://reviews.llvm.org/D42966