[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes
Mikhail Ramalho via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 2 06:35:47 PDT 2018
mikhail.ramalho added a comment.
Hi,
> Filename + offset for things like function parameters, where we have to
> identify the particular function declaration they're part of.
> For static functions themselveds, just the filename. I think this is
> current behavior in both cases.
But then we're back to the initial question, what to do when there are
linemarkers that change the filename/line number?
Should we ignore linemarkers and use filename + offset of the real file?
Should we try to calculate the offset of the decl in the virtual file?
Thank you,
Repository:
rC Clang
https://reviews.llvm.org/D42966
More information about the cfe-commits
mailing list