[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Sorry for the delay.

In https://reviews.llvm.org/D42966#1069674, @mikhail.ramalho wrote:

> Sure. Basically, the previous code would not generate the USR for the function's parameters. 
>  The issue was that SM.getFileEntryForID would return NULL because there is no actual file


Why wasn't there a file for function parameter? Function parameters *are* declared in some file, or am I missing something?

More general question is: how do we want USRs for function parameters to work, specifically should USR of the same param of different declarations be the same or different?


Repository:
  rC Clang

https://reviews.llvm.org/D42966