[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 24 08:40:43 PDT 2018


ilya-biryukov added a comment.

In https://reviews.llvm.org/D42966#1069674, @mikhail.ramalho wrote:

> Sure. Basically, the previous code would not generate the USR for the function's parameters.
>
> The issue was that SM.getFileEntryForID would return NULL because there is no actual file, that's why I changed to get the presumedLoc and build the name using the column/line.
>
> I know that using column/line not the preferable method to generate USR but I couldn't find a way to generate the offset of a presumed location.





Repository:
  rC Clang

https://reviews.llvm.org/D42966





More information about the cfe-commits mailing list