[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

[David Blaikie via cfe-commits]

On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator <
reviews at reviews.llvm.org> wrote:

> rjmccall added a comment.
>
> In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote:
>
> > Is there anything else in the "-w" namespace other than the literal "-w"
> so
> >  far?
>
>
> No. This would be novel.
>

Ah, I see.


> > I mean, I could imagine it might make more sense to default these
> warnings
> >  off & users can turn them on for non-test code, potentially? So
> >  "-Wnon-test" might make sense.
>
> That's an interesting idea, but it's still not a warning group, because
> you shouldn't get the self-assign warnings unless `-Wself-assign` is
> enabled.
>

You shouldn't? But yeah, it's tricky either way - either you get them all,
then opt out of all the warnings for test code you don't generally want.

I'll leave it to you, then - don't feel too strongly. Maybe worth seeing if
Richard has an opinion, but up to you.

- Dave


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45766
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180423/25f2b158/attachment.html>