[PATCH] D44093: [BUILTINS] structure pretty printer

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 08:25:23 PDT 2018


arichardson added a comment.

I'm also often restricted to using printf for debugging so this looks really useful!

However, before committing this I feel like the test should also verify that the format strings that are generated are sensible.

Also what should happens when you have enum members in your struct or maybe even C++ pointers to members?



================
Comment at: test/Sema/builtin-dump-struct.c:42
+  __builtin_dump_struct(&a, goodfunc2);
+}
----------------
I think there should also be a test here that we get an error when the struct contains bitfields instead of crashing/generating nonsense in CodeGen.


Repository:
  rC Clang

https://reviews.llvm.org/D44093





More information about the cfe-commits mailing list