[PATCH] D44093: [BUILTINS] structure pretty printer

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 07:57:55 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with some minor commenting nits.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:992
+
+    // We check whether we are in a recursive type
+    if (CanonicalType->isRecordType()) {
----------------
Missing full stop at the end of the comment. Same elsewhere.


================
Comment at: lib/Sema/SemaChecking.cpp:1114
+  case Builtin::BI__builtin_dump_struct: {
+    // We first want to ensure we are called with 2 arguments
+    if (checkArgCount(*this, TheCall, 2))
----------------
Missing full stop here and elsewhere as well.


Repository:
  rC Clang

https://reviews.llvm.org/D44093





More information about the cfe-commits mailing list