[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

Mikhail Dvoretckii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 5 07:09:12 PDT 2018


mike.dvoretsky added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8307
+    Dst = Ops[0];
+    Mask = llvm::ConstantInt::get(CGF.Builder.getInt32Ty(), 1);
+  } else {
----------------
craig.topper wrote:
> I'm not sure we should even try to emit a mask for the legacy scalar intrinsics. Does this get removed well by the middle or backend?
The masking is done to represent all operations handled here in a uniform way. D45203 removes it in the backend.


https://reviews.llvm.org/D45202





More information about the cfe-commits mailing list