[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

[Craig Topper via Phabricator via cfe-commits]

craig.topper added a comment.

What about rndscaless/rndscalesd?



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8307
+    Dst = Ops[0];
+    Mask = llvm::ConstantInt::get(CGF.Builder.getInt32Ty(), 1);
+  } else {
----------------
I'm not sure we should even try to emit a mask for the legacy scalar intrinsics. Does this get removed well by the middle or backend?


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8320
+      Dst = Src;
+      Mask = llvm::ConstantInt::getAllOnesValue(CGF.Builder.getInt32Ty());
+    }
----------------
Why Int32? That's not the right mask width for the legacy intrinsics.


https://reviews.llvm.org/D45202