[PATCH] D43514: Start settinng dso_local for COFF

[Eric Christopher via Phabricator via cfe-commits]

echristo added inline comments.


================
Comment at: lib/CodeGen/CodeGenModule.h:728
+  /// This must be called after dllimport/dllexport is set.
+  /// FIXME: should this set dllimport/dllexport instead?
   void setGVProperties(llvm::GlobalValue *GV, const NamedDecl *D) const;
----------------
Agreed? Maybe? Should the rest of the properties from above each call be set in this function?

Since you've got the decl it might be best to get as many of them in one place as possible?


https://reviews.llvm.org/D43514