[PATCH] D43514: Start settinng dso_local for COFF

[Rafael Avila de Espindola via Phabricator via cfe-commits]

espindola updated this revision to Diff 135547.
espindola added a comment.

Address review comments.


https://reviews.llvm.org/D43514

Files:
  lib/CodeGen/CGDecl.cpp
  lib/CodeGen/CodeGenModule.cpp
  lib/CodeGen/CodeGenModule.h
  lib/CodeGen/ItaniumCXXABI.cpp
  test/CodeGen/aarch64-varargs-ms.c
  test/CodeGen/attr-x86-interrupt.c
  test/CodeGen/blocks-windows.c
  test/CodeGen/builtins-ms.c
  test/CodeGen/builtins-overflow.c
  test/CodeGen/c-strings.c
  test/CodeGen/cfi-icall-cross-dso.c
  test/CodeGen/cfi-icall.c
  test/CodeGen/cfstring-windows.c
  test/CodeGen/dllexport.c
  test/CodeGen/dllimport.c
  test/CodeGen/dso-local-executable.c
  test/CodeGen/exceptions-seh-finally.c
  test/CodeGen/exceptions-seh-leave.c
  test/CodeGen/exceptions-seh.c
  test/CodeGen/inline.c
  test/CodeGen/mangle-ms.c
  test/CodeGen/mangle-windows-rtd.c
  test/CodeGen/mangle-windows.c
  test/CodeGen/microsoft-call-conv-x64.c
  test/CodeGen/mingw-long-double.c
  test/CodeGen/ms-align-tentative.c
  test/CodeGen/ms-annotation.c
  test/CodeGen/ms-barriers-intrinsics.c
  test/CodeGen/ms-declspecs.c
  test/CodeGen/ms-declspecs.cpp
  test/CodeGen/ms-inline-asm-align.c
  test/CodeGen/ms-inline-asm-avx512.c
  test/CodeGen/ms-intrinsics.c
  test/CodeGen/ms-setjmp.c
  test/CodeGen/ms-x86-intrinsics.c
  test/CodeGen/ms_abi.c
  test/CodeGen/ms_abi_aarch64.c
  test/CodeGen/ms_this.cpp
  test/CodeGen/preserve-call-conv.c
  test/CodeGen/regcall.c
  test/CodeGen/variadic-null-win64.c
  test/CodeGen/vectorcall.c
  test/CodeGen/windows-itanium.c
  test/CodeGen/windows-on-arm-dllimport-dllexport.c
  test/CodeGen/windows-struct-abi.c
  test/CodeGen/windows-swiftcall.c
  test/CodeGen/x86_32-arguments-win32.c
  test/CodeGen/x86_32-fpcc-struct-return.c
  test/CodeGen/x86_64-arguments-win32.c
  test/CodeGenCXX/PR19955.cpp
  test/CodeGenCXX/atomic-dllexport.cpp
  test/CodeGenCXX/attr-x86-interrupt.cpp
  test/CodeGenCXX/constructor-destructor-return-this.cpp
  test/CodeGenCXX/dllexport-alias.cpp
  test/CodeGenCXX/dllexport-ctor-closure.cpp
  test/CodeGenCXX/dllexport-dtor-thunks.cpp
  test/CodeGenCXX/dllexport-members.cpp
  test/CodeGenCXX/dllexport-ms-friend.cpp
  test/CodeGenCXX/dllexport-pr26549.cpp
  test/CodeGenCXX/dllexport-vtable-thunks.cpp
  test/CodeGenCXX/dllexport.cpp
  test/CodeGenCXX/dllimport-dtor-thunks.cpp
  test/CodeGenCXX/dllimport-members.cpp
  test/CodeGenCXX/dllimport-memptr-global.cpp
  test/CodeGenCXX/dllimport-rtti.cpp
  test/CodeGenCXX/dllimport.cpp
  test/CodeGenCXX/exceptions-cxx-ehsc.cpp
  test/CodeGenCXX/exceptions-cxx-new.cpp
  test/CodeGenCXX/exceptions-seh-filter-captures.cpp
  test/CodeGenCXX/exceptions-seh.cpp
  test/CodeGenCXX/explicit-instantiation.cpp
  test/CodeGenCXX/homogeneous-aggregates.cpp
  test/CodeGenCXX/initializer-list-ctor-order.cpp
  test/CodeGenCXX/inline-dllexport-member.cpp
  test/CodeGenCXX/inline-functions.cpp
  test/CodeGenCXX/mangle-ms-cxx11.cpp
  test/CodeGenCXX/mangle-ms-md5.cpp
  test/CodeGenCXX/mangle-ms-templates-memptrs-2.cpp
  test/CodeGenCXX/mangle-ms-vector-types.cpp
  test/CodeGenCXX/mangle-ms.cpp
  test/CodeGenCXX/mangle-windows.cpp
  test/CodeGenCXX/member-function-pointer-calls.cpp
  test/CodeGenCXX/microsoft-abi-arg-order.cpp
  test/CodeGenCXX/microsoft-abi-array-cookies.cpp
  test/CodeGenCXX/microsoft-abi-byval-sret.cpp
  test/CodeGenCXX/microsoft-abi-byval-thunks.cpp
  test/CodeGenCXX/microsoft-abi-byval-vararg.cpp
  test/CodeGenCXX/microsoft-abi-cdecl-method-sret.cpp
  test/CodeGenCXX/microsoft-abi-constexpr-vs-inheritance.cpp
  test/CodeGenCXX/microsoft-abi-default-cc.cpp
  test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp
  test/CodeGenCXX/microsoft-abi-eh-catch.cpp
  test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp
  test/CodeGenCXX/microsoft-abi-eh-inlineasm.cpp
  test/CodeGenCXX/microsoft-abi-eh-terminate.cpp
  test/CodeGenCXX/microsoft-abi-extern-template.cpp
  test/CodeGenCXX/microsoft-abi-member-pointers.cpp
  test/CodeGenCXX/microsoft-abi-methods.cpp
  test/CodeGenCXX/microsoft-abi-multiple-nonvirtual-inheritance.cpp
  test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp
  test/CodeGenCXX/microsoft-abi-static-initializers.cpp
  test/CodeGenCXX/microsoft-abi-structors-alias.cpp
  test/CodeGenCXX/microsoft-abi-structors.cpp
  test/CodeGenCXX/microsoft-abi-thread-safe-statics.cpp
  test/CodeGenCXX/microsoft-abi-thunks.cpp
  test/CodeGenCXX/microsoft-abi-try-throw.cpp
  test/CodeGenCXX/microsoft-abi-typeid.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance-vtordisps.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
  test/CodeGenCXX/microsoft-abi-virtual-member-pointers.cpp
  test/CodeGenCXX/microsoft-abi-vmemptr-conflicts.cpp
  test/CodeGenCXX/microsoft-abi-vmemptr-vbase.cpp
  test/CodeGenCXX/microsoft-abi-vtables-multiple-nonvirtual-inheritance-this-adjustment.cpp
  test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance.cpp
  test/CodeGenCXX/microsoft-compatibility.cpp
  test/CodeGenCXX/microsoft-inaccessible-base.cpp
  test/CodeGenCXX/microsoft-interface.cpp
  test/CodeGenCXX/mingw-new-abi.cpp
  test/CodeGenCXX/mingw-w64-seh-exceptions.cpp
  test/CodeGenCXX/ms-eh-personality.cpp
  test/CodeGenCXX/ms-inline-asm-return.cpp
  test/CodeGenCXX/ms-integer-static-data-members-exported.cpp
  test/CodeGenCXX/ms-integer-static-data-members.cpp
  test/CodeGenCXX/ms-property.cpp
  test/CodeGenCXX/ms-thread_local.cpp
  test/CodeGenCXX/naked.cpp
  test/CodeGenCXX/pr20897.cpp
  test/CodeGenCXX/pr27030.cpp
  test/CodeGenCXX/pr28360.cpp
  test/CodeGenCXX/pr30731.cpp
  test/CodeGenCXX/pragma-init_seg.cpp
  test/CodeGenCXX/regcall.cpp
  test/CodeGenCXX/rtti-mingw64.cpp
  test/CodeGenCXX/runtime-dllstorage.cpp
  test/CodeGenCXX/sections.cpp
  test/CodeGenCXX/type-metadata.cpp
  test/CodeGenCXX/ubsan-vtable-checks.cpp
  test/CodeGenCXX/uncopyable-args.cpp
  test/CodeGenCXX/vararg-non-pod-ms-compat.cpp
  test/CodeGenCXX/vtable-assume-load.cpp
  test/CodeGenCXX/vtable-key-function-ios.cpp
  test/CodeGenCXX/vtable-key-function-win-comdat.cpp
  test/CodeGenCXX/windows-itanium-type-info.cpp
  test/CodeGenCoroutines/coro-promise-dtor.cpp
  test/CodeGenObjCXX/microsoft-abi-arc-param-order.mm
  test/CodeGenObjCXX/msabi-objc-types.mm
  test/PCH/uses-seh.cpp