[PATCH] D42645: New simple Checker for mmap calls

[David CARLIER via Phabricator via cfe-commits]

devnexen added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until the state changes
----------------
emaste wrote:
> I'm a bit confused by this comment; this checker works as-is for most common operating system cases, correct?
Most of them yes, at least Muslc linux most of glibc I tested too. Not to mention *BSD ... But might be safer to put it as alpha for a start.


================
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:64
+      if (!BT)
+        BT.reset(new BugType(this, "W^X check fails, Write Exec prot flags set", "Security"));
+
----------------
emaste wrote:
> `Write & Exec` (or `Write and Exec`) perhaps (assuming it doesn't become over-long then)?
I kept short intentionally indeed we can always change but the user in order to use it needs to enable it willingly so I assumed the user might know enough about the topic in question.


https://reviews.llvm.org/D42645