[PATCH] D42645: New simple Checker for mmap calls

[Ed Maste via Phabricator via cfe-commits]

emaste added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until the state changes
----------------
I'm a bit confused by this comment; this checker works as-is for most common operating system cases, correct?


================
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:64
+      if (!BT)
+        BT.reset(new BugType(this, "W^X check fails, Write Exec prot flags set", "Security"));
+
----------------
`Write & Exec` (or `Write and Exec`) perhaps (assuming it doesn't become over-long then)?


https://reviews.llvm.org/D42645