[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

Jake Ehrlich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 16 12:17:57 PST 2018


jakehehrlich added a comment.

> I'd like a test for #pragma GCC visibility push(hidden) which should cause each symbol to be treated as though it were explicitly hidden.

To clarify, this check should still give a warning if the specified variable doesn't actually have that in source code. e.g. simply because "#pragma GCC visibility push(hidden)" was at the top dosn't mean these functions should get a pass.


https://reviews.llvm.org/D43392





More information about the cfe-commits mailing list