[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

[Jake Ehrlich via Phabricator via cfe-commits]

jakehehrlich added a comment.

I'd like a test for #pragma GCC visibility push(hidden) which should cause each symbol to be treated as though it were explicitly hidden.



================
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:32
+  if (Name.empty()) return;
+  Finder->addMatcher(functionDecl(allOf(hasName(Name), isDefinition(),
+                                        unless(hasVisibilityAttr())))
----------------
aaron.ballman wrote:
> Would it make more sense to store a list of names and then find all of them at once, rather than a single name at a time?
+1 on this we generally want to make this change to many different functions at the same time.


https://reviews.llvm.org/D43392